-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124162/#review81913
-----------------------------------------------------------



src/file/extractor/org.kde.balooExtractor.xml (line 3)
<https://git.reviewboard.kde.org/r/124162/#comment56253>

    Sorry, the generated header does not like to be included from inside a 
namespace.
    
    The following works:
    
    ```
    #include "baloo_interface.h"
    #include "extractor_interface.h"
    
    namespace org {
      namespace kde {
        typedef ::OrgKdeBalooInterface BalooInterface;
        namespace baloo {
          typedef ::OrgKdeBalooExtractorInterface ExtractorInterface;
    }}}
    ```
    
    qdbusxml2cpp -N -p extractor_interface org.kde.balooExtractor.xml
    qdbusxml2cpp -N -p baloo_interface org.kde.baloo.xml


- Stefan Brüns


On June 30, 2015, 4:45 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124162/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 4:45 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Every monitor now, has to register with the extractor. The extractor keeps 
> track of running monitors and only sends out the urlChanged signal if one or 
> more monitors are running.
> 
> 
> Diffs
> -----
> 
>   src/file/extractor/app.h f8b8834 
>   src/file/extractor/app.cpp e288285 
>   src/file/extractor/main.cpp 58ddbeb 
>   src/file/extractor/org.kde.balooExtractor.xml PRE-CREATION 
>   src/tools/baloo-monitor/CMakeLists.txt 646f701 
>   src/tools/baloo-monitor/monitor.h c7dc76f 
>   src/tools/baloo-monitor/monitor.cpp 46e7a02 
> 
> Diff: https://git.reviewboard.kde.org/r/124162/diff/
> 
> 
> Testing
> -------
> 
> Tested using dbus-monitor, extractor only exports urls when monitor is 
> running.
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to