> On June 12, 2015, 3:45 p.m., Vishesh Handa wrote: > > I'm fine with this simple approach as a starting point, but I'm not sure if > > FileContentIndexer is the correct place. I am not quite sure how you're > > planning to hook this up with the monitor. > > > > Also has this been tested? > > Pinak Ahuja wrote: > * That is exaclty what this is meant to be, a starting point I'll be > testing and refining it further. > * I'll put in a method in the scheduler class which will be exported over > Dbus and will call this method from the ContentFileIndexer instance. In the > monitor the exported method will be called after a fixed time/files to update > the remaining time. > * Nope testing hasn't been done yet, in it's current state it's pretty > hard to test as the FileContentIndexer isn't hooked up and testing it > separately would require us mocking the extractor which wouldn't give > realistic results.
Alright. Add the simple executable to test out the content indexer, and then start testing out all the parts. This all can go in another branch if you want to go faster. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124082/#review81412 ----------------------------------------------------------- On June 12, 2015, 1:42 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124082/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 1:42 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This method will be eventually be exported via dbus and we'll be able to > query the estimated time on demand. > Would calling timeRemaining() from the main application while runnable is > running in a separate thread work properly? > > > Diffs > ----- > > src/file/filecontentindexer.h cf31686 > src/file/filecontentindexer.cpp df218a7 > > Diff: https://git.reviewboard.kde.org/r/124082/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
