----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124075/#review81399 -----------------------------------------------------------
src/file/extractorprocess.h (line 46) <https://git.reviewboard.kde.org/r/124075/#comment55766> src/file/extractorprocess.cpp (line 71) <https://git.reviewboard.kde.org/r/124075/#comment55765> The ids are already being converts to urls in the extractor. We should do all of this over there. - Vishesh Handa On June 11, 2015, 8:25 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124075/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 8:25 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > The batchStart signal gives us the urls of files we are about to index. We > will assume the indexing the of the first file has started as soon as this > signal is caught and the fileDone() signal tells us that the file is done. > > > Diffs > ----- > > src/file/CMakeLists.txt 16bc6dd > src/file/extractorprocess.h 3106a71 > src/file/extractorprocess.cpp 38c2493 > src/file/filecontentindexer.cpp df218a7 > src/file/filecontentindexerprovider.h e5f8d2a > src/file/org.kde.baloo.file.contentindexer.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124075/diff/ > > > Testing > ------- > > Not tested yet as the filecontentindexer is not hooked up to the main code. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
