----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124063/#review81388 -----------------------------------------------------------
The method of calculation of the document size isn't very accurate. * It's quite hard to approximate the size used by the postingDB + positionDB. * For the PostingDB you are using 64 bytes. I'm not sure how that translates. * For the PositionDB it's even more complex. Also, when/if the PositionCodec implementation changes, the current code breaks. * For the other databases, we actually need to take the pagesize of the db and the header size into consideration, since they also consume space. Also there is a concept of overflow pages. All of this is generally taken care of by the MDB_stat method. But doing it per document will be hard. Maybe you could drop this for now and focus on other stuff? - Vishesh Handa On June 10, 2015, 4:44 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124063/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 4:44 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This method tries to approximate the space a file's data is taking in the > index. > balooctl status [file..] now also shows this information. > > > Diffs > ----- > > src/engine/transaction.h d7f0715 > src/engine/transaction.cpp f343f53 > src/tools/balooctl/main.cpp 8413621 > > Diff: https://git.reviewboard.kde.org/r/124063/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
