On Wed, Jan 21, 2015 at 3:36 AM, David Faure <fa...@kde.org> wrote: > On Wednesday 21 January 2015 02:33:39 you wrote: >> But I think the parent of that porting patch would be a commit that is >> not in the kio repo. Anyhow, the repo to review is at >> >> g...@git.kde.org:clones/kio/narvaez/kio-new-protocols.git >> >> let me know if you find any issues with it. If it is OK, then I'll >> transplant the code into g...@git.kde.org:kio. > > Thanks! > > First issue: the thumbnail ioslave isn't getting compiled, the > add_subdirectory is missing in src/ioslaves. > > Second issue: FindExiv2.cmake is missing. It seems that it came from > kdelibs4support, it's also in extra-cmake-modules/attic/modules. > > Third issue: Unknown CMake command "macro_bool_to_01". > I think we can just use EXIV2_FOUND and remove HAVE_EXIV2. > > Oh, there's more... > > Target "comicbookthumbnail" links to target "KF5::Pty" > Target "kio_thumbnail" links to target "KF5::KDELibs4Support" > > Or do you have a commit for all this, but not in the repo yet?
Yes, I have a patch that adds the thumbnail subdir and fixes the build, but it is not in the repo yet. The repo is mainly about the issues mentioned below. > The repo history looks fine to me, although I'm not exactly sure what to check > (I checked the general shape of the tree, tags, branches...) That's one thing... > Ah, one thing that's surprising is that the oldest entry in "git log" is > 77c4ac1f (Imported KDE Control Center Application) rather than > 1c03f63 (Initial import from the monolithic kdelibs). > But the tree looks ok, so I'm not sure how this happens? > git log sorts purely by date? ... and this is another thing but I don't know what the proper answer is here (i.e., I don't know how the history should look like). I'm guessing it sortes purely by date. David E. Narvaez >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
