----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120266/#review66850 -----------------------------------------------------------
Ship it! Great! If you want to slightly increase test coverage, you can add a test like "fileSize < 2048" so that you check that LessThan is not changed to Equals by the integer value. - Denis Steckelmacher On Sept. 18, 2014, 3:38 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120266/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 3:38 p.m.) > > > Review request for Baloo and Denis Steckelmacher. > > > Repository: baloo > > > Description > ------- > > We need to convert them to the proper types so that the backends can react to > them. I've only added support for the ISO date > > > Diffs > ----- > > src/core/advancedqueryparser.cpp c7897ad > src/core/autotests/advancedqueryparsertest.h 6319c0e > src/core/autotests/advancedqueryparsertest.cpp 530993a > > Diff: https://git.reviewboard.kde.org/r/120266/diff/ > > > Testing > ------- > > Added a unit test. > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
