----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119897/#review65186 -----------------------------------------------------------
Ship it! Go ahead. These are just minor issues. src/groupedlineedit.h <https://git.reviewboard.kde.org/r/119897/#comment45547> You might want to fix the coding style in the this commit. We typically don't add the extra indentation. src/groupedlineedit.cpp <https://git.reviewboard.kde.org/r/119897/#comment45548> This can be renamed to Baloo if you want :) src/groupedlineedit.cpp <https://git.reviewboard.kde.org/r/119897/#comment45549> Could you please add a comment here. I'm not too sure why we have a 0x7; I know this is not related to the KF5 port so maybe it can be done in another commit. src/groupedlineedit.cpp <https://git.reviewboard.kde.org/r/119897/#comment45550> This might not be required. test/CMakeLists.txt <https://git.reviewboard.kde.org/r/119897/#comment45551> No, KF5::BalooWidgets? Maybe we don't export that as an alias. - Vishesh Handa On Aug. 22, 2014, 9:24 a.m., Denis Steckelmacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119897/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 9:24 a.m.) > > > Review request for Baloo. > > > Repository: baloo-widgets > > > Description > ------- > > This patch ports the QueryBuilder widget to Baloo 5 and KF5 and adds > auto-completion for file properties. > > > Diffs > ----- > > test/CMakeLists.txt 2e7a737 > test/querybuilderapp.cpp PRE-CREATION > src/querybuilder.cpp PRE-CREATION > src/querybuildercompleter.cpp PRE-CREATION > src/querybuildercompleter_p.h PRE-CREATION > src/groupedlineedit.h PRE-CREATION > src/groupedlineedit.cpp PRE-CREATION > src/querybuilder.h PRE-CREATION > CMakeLists.txt 8e242b8 > src/CMakeLists.txt 367c93d > > Diff: https://git.reviewboard.kde.org/r/119897/diff/ > > > Testing > ------- > > The query builder test application compiles, launches and works as expected, > as does the auto-completion for file properties (screenshot attached). The > screenshot does not show it, but "width > 400", "artist contains KDE" and > things like that work. > > > File Attachments > ---------------- > > Code-completion for file properties > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/0ba129e4-56b7-472c-8dac-3b5044bb5a80__baloo-properties-completion.png > > > Thanks, > > Denis Steckelmacher > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
