> On Aug. 12, 2014, 9:07 a.m., Vishesh Handa wrote: > > src/qml/test/baloodatamodeltest.cpp, line 43 > > <https://git.reviewboard.kde.org/r/119717/diff/2/?file=303908#file303908line43> > > > > I'm confused. Wouldn't this return a different number of everyone's > > system? > > Antonis Tsiapaliokas wrote: > Well no, unless i don't understand something right here. > Since i am using the setLimit, it will return only the first 5 items. > Do you mean that it will return less items, in the case that someone has > indexed less than 5 items?
Yes. Jenkins will not have any indexed documents. Nor will a fresh system. > On Aug. 12, 2014, 9:07 a.m., Vishesh Handa wrote: > > src/qml/test/baloodatamodeltest.cpp, line 29 > > <https://git.reviewboard.kde.org/r/119717/diff/2/?file=303908#file303908line29> > > > > The typical convention is to put private variables in the bottom. Also, > > maybe we could just initialize this in the checkModelCount() function. > > > > If we allocate it off the stack, then we won't be leaking memory like > > we are right now. > > Antonis Tsiapaliokas wrote: > Sorry but but i don't get it. > Do you mean that the BalooDataModel should be removed from the private > members > and it should be a non pointer object? yes - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119717/#review64355 ----------------------------------------------------------- On Aug. 13, 2014, 7:45 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119717/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 7:45 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > The BalooDataModel should be cleared before we store the data for our next > query. > > > Diffs > ----- > > src/qml/baloodatamodel.cpp edcd540 > src/qml/autotests/baloodatamodeltest.cpp PRE-CREATION > src/qml/autotests/CMakeLists.txt PRE-CREATION > src/qml/CMakeLists.txt 6ee68c0 > > Diff: https://git.reviewboard.kde.org/r/119717/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
