> On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 53 > > <https://git.reviewboard.kde.org/r/119543/diff/1/?file=294417#file294417line53> > > > > Hmm. There is too much space between the new and KBlockLayout. > > > > Also, since we're loosing the spacingHint, could you please add a FIXME > > over here?
yes i will do. > On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 101 > > <https://git.reviewboard.kde.org/r/119543/diff/1/?file=294417#file294417line101> > > > > It would be nice if changes which are related to just fixing the faulty > > coding style could go in a separate commit. ok > On Juli 30, 2014, 10:54 vorm., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > <https://git.reviewboard.kde.org/r/119543/diff/1/?file=294417#file294417line180> > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > > > > Also, if one really doesn't need it to be split up, then we should > > probably use a QScopedPointer instead of deleting it outself. i did googling yesterday and i think it is not needed. I am not a fan of class members. you didnt see the dataflow. We should i use a QScopedPointer? - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/#review63489 ----------------------------------------------------------- On Juli 30, 2014, 8:29 vorm., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119543/ > ----------------------------------------------------------- > > (Updated Juli 30, 2014, 8:29 vorm.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo-widgets > > > Description > ------- > > Removed all KDialogs from balooWidgets. Removed not needed includes > > > Diffs > ----- > > src/tagwidget.h 2843acd > src/tagwidget.cpp f2c3601 > src/tagwidget_p.h 045a185 > src/filemetadataconfigwidget.cpp 561ab7b > src/filemetadatawidget.cpp 24e4ee3 > src/kcommentwidget.cpp 5191b03 > src/kedittagsdialog.cpp c83ce9d > src/kedittagsdialog_p.h 0bcf744 > src/tagcheckbox.cpp af07a6c > > Diff: https://git.reviewboard.kde.org/r/119543/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
