----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119450/#review63063 -----------------------------------------------------------
Hi. Could you please follow the coding style over here - https://techbase.kde.org/Policies/Kdelibs_Coding_Style/en . In general just try to follow the coding style given in the file. Overall, these changes are fine. How about we talk about what all changes you want to make on the tests? The current stuff tests added is being tested by the other tests as well. But then the tests are definitely not small. Plus, I'd like to avoid making too many changes in qt4 since all development is currently happening in the frameworks branch. You can find me on freenode as vHanda or Google+. - Vishesh Handa On July 24, 2014, 8:49 a.m., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119450/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 8:49 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Hi vHanda > because of the little patch yesterday i decide i want to contribute to baloo > framework. I saw that not many unittests are pressent yet. So i think to > learn about the framework, it is helpful to write unittests. > I am a very big fan of test driven development. I would like to use this but > this break the current style. > I am a fan of the "AAA" concept (arrange,act,assert) according to that > unittests are very simple and small and only one thing will be tested. > What do you think about this idea to do in baloo? > > > Diffs > ----- > > src/file/autotest/filemonitortest.cpp 19d8f85 > > Diff: https://git.reviewboard.kde.org/r/119450/diff/ > > > Testing > ------- > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
