> On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > I know this is not a review for me, but I was curious :-)
This review is for everyone how cares, and I always appreciate your input =) > On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > src/pim/agent/collectionindexer.cpp, line 65 > > <https://git.reviewboard.kde.org/r/119441/diff/1/?file=292237#file292237line65> > > > > Are you sure that ancestors are fetched with attributes for > > .displayName() to work? That's why CollectionUpdateJob fetches all ancestors and replaces the the collection copy with one that contains all required details. > On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > src/pim/agent/collectionindexer.cpp, line 113 > > <https://git.reviewboard.kde.org/r/119441/diff/1/?file=292237#file292237line113> > > > > Didn't you already handled empty NS term on l. 103? I think this entire > > block could be just moves into the > > > > if (!folderAttribute->collectionName().isEmpty()) { ... } block We also have to index "NS" if the attribute is not available at all, but the else clause is redundant indeed. - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/#review63032 ----------------------------------------------------------- On July 23, 2014, 10:14 p.m., Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119441/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 10:14 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Akonadi-Indexer: Collection indexing > > Index that allows to search for collections. > > > Diffs > ----- > > src/pim/agent/CMakeLists.txt 0a1ef087e6cf3c1c293278c38cecfc8086b4fd58 > src/pim/agent/agent.h 439936be7e0c84544fd4ab72f9a3ddc19ac1ab21 > src/pim/agent/agent.cpp 5231e9d2ef230433032e28a52eb0f0346bf2f176 > src/pim/agent/autotests/CMakeLists.txt > 604b35244f01e4e0667212be9c9c3aa41c6958af > src/pim/agent/autotests/collectionquerytest.cpp PRE-CREATION > src/pim/agent/collectionindexer.h PRE-CREATION > src/pim/agent/collectionindexer.cpp PRE-CREATION > src/pim/agent/collectionupdatejob.h PRE-CREATION > src/pim/agent/collectionupdatejob.cpp PRE-CREATION > src/pim/agent/index.h 8d59d727d53c1320f63e4c4fe572c434f5e76ff6 > src/pim/agent/index.cpp 2aa105b2210129d3824f97cc3695bd50d034df67 > src/pim/agent/org.freedesktop.Akonadi.BalooIndexer.xml > b3b379d96667ec02783747ba3633962d73edccc6 > src/pim/agent/scheduler.h 805986b87e269d957516bb1ce3e2aff990f8ab8a > src/pim/agent/scheduler.cpp 5eef1e725d1ad22d40dc46cffa53d57954f25e88 > src/pim/lib/CMakeLists.txt 3f445339374df6a1acb83c61833e61faf05505ff > src/pim/lib/collectionquery.h PRE-CREATION > src/pim/lib/collectionquery.cpp PRE-CREATION > src/pim/lib/resultiterator.h 7c0505c08935d8b14e261a5bd42db0cd807538f3 > > Diff: https://git.reviewboard.kde.org/r/119441/diff/ > > > Testing > ------- > > > Thanks, > > Christian Mollekopf > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
