> On June 17, 2014, 9:43 a.m., Vishesh Handa wrote: > > src/file/basicindexingjob.cpp, line 32 > > <https://git.reviewboard.kde.org/r/118752/diff/2/?file=281845#file281845line32> > > > > I'm a little surprised this works. Could you please add the explicit > > <KFileMetaData/TypeInfo> instead. This way it is obvious where it comes > > from. > > > > In this case I agree with the whole Python mantra of "Explicit is > > better than implicit" > > Matthew Dawson wrote: > I would have actually preferred to use that form for the includes, > however it appears that the build system does not properly setup the include > directories to allow that form. When compiling most of Baloo, > /usr/include/KF5 is in the include path (seen by checking the actual > compilation command). However, at least one unit test and one executable do > not. > > In both cases, /usr/include/KF5/KFileMetaData is in the include path > (again verified by inspecting the compilation command). I don't know why the > include path changes, as of right now switching the includes will break. > > I think this patch as is should go in, as otherwise Baloo won't compile > at all. I can then start chasing down the problems with doing this change, > and fix it later. > > Matthew Dawson wrote: > ping > > Does this still need to be fixed for this patch to be committed? I > haven't had time to chase down why the explicit form doesn't work yet. > > Also, can I commit https://git.reviewboard.kde.org/r/118670/ (with proper > attribution) as well, since the author doesn't have commit access? Otherwise > this patch can't be committed at all :) > > Vishesh Handa wrote: > Hey. > > Yes, this can go in and you can work on fixing the rest. Would it be all > right if I committed this patch and the KFileMetadata one? I don't want to > push one and not the other since stuff will break. > > Or if you really want you can do it.
That is fine, feel free to commit away! I don't prefer who does it. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118752/#review60251 ----------------------------------------------------------- On June 16, 2014, 6:05 p.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118752/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 6:05 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Fix Baloo to work against frameworkified KFileMetaData. > > Change Baloo to find KFileMetaData as a proper framework, and change the > necessary include statements. > > > Diffs > ----- > > src/tools/balooshow/main.cpp db0acb019c9bda696775150ccc4f6007fec7be82 > src/file/search/filesearchstore.cpp > 0b1a6201ed7ae12f776daf2392313406d0168de3 > src/file/search/CMakeLists.txt 5549943aaf98026a698b4a4ae6bba4df01699012 > src/file/lib/file_p.h a4fcf44325a360149fa646e8b8adb15c68a6b20e > src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b > src/file/lib/autotests/filefetchjobtest.cpp > f9c49ff30ee119950603f1b9628c14fffe0bd5dd > src/file/extractor/result.cpp b2d5615ce3645d6e0ff435b3771539e1aeea5380 > src/file/extractor/result.h 3dbde3d333076543f141859b074da47d1ed593c2 > src/file/extractor/app.cpp 00c250e5796c58b0fb1a7b7f8ba7849df557f56e > src/file/extractor/app.h 9e674d369fb25538ed971dce9026fe53d697db3e > src/file/basicindexingjob.cpp b53cd79ccded7ce901cfd80c1eea119c6f6ab121 > src/file/basicindexingjob.h f72680c499de5f6d48a1b2bdedceb1877101e3b2 > CMakeLists.txt 7a07aa465601d4d196e9fa9158c05d1573d0f90d > > Diff: https://git.reviewboard.kde.org/r/118752/diff/ > > > Testing > ------- > > Compiles and tests fine. > > > Thanks, > > Matthew Dawson > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
