> On June 10, 2014, 12:16 p.m., Bhushan Shah wrote: > > CMakeLists.txt, line 64 > > <https://git.reviewboard.kde.org/r/118628/diff/1/?file=279885#file279885line64> > > > > hmm what about using ecm_add_test?
That's already used in autotests/CMakeLists.txt - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118628/#review59672 ----------------------------------------------------------- On June 9, 2014, 5:11 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118628/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 5:11 p.m.) > > > Review request for Baloo. > > > Repository: kfilemetadata > > > Description > ------- > > Make tests behave more like frameworks, by respecting the BUILD_TESTING > option from ECM and only locating QtTest when necessary. The default > behaviour remains the same. > > > Diffs > ----- > > CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2 > autotests/CMakeLists.txt 95c3e302122d3b9a01f70e74812c2b374ac46023 > > Diff: https://git.reviewboard.kde.org/r/118628/diff/ > > > Testing > ------- > > Tests pass/are ignored with the appropriate build option. > > > Thanks, > > Michael Palimaka > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
