----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117187/#review54598 -----------------------------------------------------------
Ship it! looks ok - Aleix Pol Gonzalez On March 30, 2014, 11:45 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117187/ > ----------------------------------------------------------- > > (Updated March 30, 2014, 11:45 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > malloc_trim(3) is a GNU extension and thus should not be used > unconditionally. > > Solve this problem by adding more checks to ConfigureChecks.cmake and using > a config.h so that we only use non-standard features if their presence has > been detected at configuration time. > > > Diffs > ----- > > CMakeLists.txt 977eaf7e99da7742d5ea87ecb10df8c2355f81db > ConfigureChecks.cmake 34db1e47338002d83250c5e3276bf207c477c30f > config.h.cmake PRE-CREATION > src/xapian/xapiandatabase.cpp d139ea70e60236a91e716e8ace03f4e01bb55706 > > Diff: https://git.reviewboard.kde.org/r/117187/diff/ > > > Testing > ------- > > I can build baloo on FreeBSD again, all tests pass. > > > Thanks, > > Raphael Kubo da Costa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
