----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114805/#review46585 -----------------------------------------------------------
src/tools/balooshow/main.cpp <https://git.reviewboard.kde.org/r/114805/#comment33249> How about allocating this off the stack instead of the heap? Basically, using QVector<QUrl> urls; instead of using new. src/tools/balooshow/main.cpp <https://git.reviewboard.kde.org/r/114805/#comment33250> This would print the incorrect error message when anything but the first url is not a local file. src/tools/balooshow/main.cpp <https://git.reviewboard.kde.org/r/114805/#comment33251> Please use Q_FOREACH (const QUrl& url, urls) { ... }. It makes the code much easier to read. - Vishesh Handa On Jan. 1, 2014, 10:46 p.m., Benjamin Kaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114805/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2014, 10:46 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Modified to now accept multiple file inputs. > Modified to print the file url colored. > Modified the look to suit multiple files (with a preceding \t on data) > > GCI Task: > http://www.google-melange.com/gci/task/view/google/gci2013/5874117316182016 > > > Diffs > ----- > > src/tools/balooshow/main.cpp 6419b9f > > Diff: https://git.reviewboard.kde.org/r/114805/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Kaiser > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
