Hi all!
I updated to 4.9.90 a few days ago, and it now seems that as of commit
8b5d78dd [1] ("disabled look to minimized tasks") by Marco Martin, the
minimized windows in taskbar have now "disabled"-looking icons as well
as text.
Unfortunately, this severely impedes the usability of my desktop, since
I have dozens of minimized windows open, and for the last few days it
has taken a very long time to find specific windows from the taskbar.
The icons used to make different applications significantly stand out
from crowd, but now they are all just grey mass.
AFAICS the options are to either
a) Add configuration option
b) Revert
c) Do not care.
Unfortunately (a) is not an option during messages freeze, so I propose
to revert the commit (and maybe add it again with a configuration option
for the next release, if the feature really is something that other
people want). In addition, the commit was seemingly made during features
freeze, so wasn't it wrong to being with?
Anyway, attached are two git patches for a full or partial revert of the
commit.
I'm willing to drop the issue if indeed I am the only one who is hit by
this, but I'd guess I'm not (though it might not be as severe for people
with less windows), and therefore suggest a revert at least until the
next release cycle.
WDYT?
[1]
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/8b5d78dd4213eb110a156fd73a7ca9323afb6f2d
--
Anssi Hannula
>From 592dc1e741410576856d3f4c3bbe48489594caad Mon Sep 17 00:00:00 2001
From: Anssi Hannula <anssi.hann...@iki.fi>
Date: Mon, 10 Dec 2012 23:30:12 +0200
Subject: [PATCH] Revert "disabled look to minimized tasks"
Feature freeze is in effect and that commit degrades usability for some
people.
This reverts commit 8b5d78dd4213eb110a156fd73a7ca9323afb6f2d.
---
plasma/desktop/applets/tasks/abstracttaskitem.cpp | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/plasma/desktop/applets/tasks/abstracttaskitem.cpp b/plasma/desktop/applets/tasks/abstracttaskitem.cpp
index 988b6a8..d57c153 100644
--- a/plasma/desktop/applets/tasks/abstracttaskitem.cpp
+++ b/plasma/desktop/applets/tasks/abstracttaskitem.cpp
@@ -684,15 +684,7 @@ void AbstractTaskItem::drawTask(QPainter *painter, const QStyleOptionGraphicsIte
kDebug() << bool(option->state & QStyle::State_MouseOver) << m_backgroundFadeAnim <<
(m_backgroundFadeAnim ? m_backgroundFadeAnim->state() : QAbstractAnimation::Stopped);*/
const bool fadingBg = m_backgroundFadeAnim && m_backgroundFadeAnim->state() == QAbstractAnimation::Running;
-
- //disabled look if the task is minimized
- //AND show only minimized tasks is disabled
- if ((m_flags & TaskIsMinimized) && !m_applet->groupManager().showOnlyMinimized()) {
- KIconEffect *effect = KIconLoader::global()->iconEffect();
- QPixmap result = icon().pixmap(iconR.toRect().size());
- result = effect->apply(result, KIconLoader::Desktop, KIconLoader::DisabledState);
- painter->drawPixmap(iconR.topLeft(), result);
- } else if ((!fadingBg && !(option->state & QStyle::State_MouseOver)) ||
+ if ((!fadingBg && !(option->state & QStyle::State_MouseOver)) ||
(m_oldBackgroundPrefix != "hover" && m_backgroundPrefix != "hover")) {
// QIcon::paint does some alignment work and can lead to funny
// things when icon().size() != iconR.toRect().size()
@@ -1121,7 +1113,7 @@ QColor AbstractTaskItem::textColor() const
color = theme->color(Plasma::Theme::TextColor);
}
- if ((m_flags & TaskIsMinimized) && !m_applet->groupManager().showOnlyMinimized()) {
+ if (m_flags & TaskIsMinimized) {
color.setAlphaF(0.5);
}
--
1.7.10
>From 4f7c67c0f33e9abf036dcd0549f98b121b4beee7 Mon Sep 17 00:00:00 2001
From: Anssi Hannula <anssi.hann...@iki.fi>
Date: Mon, 10 Dec 2012 23:34:23 +0200
Subject: [PATCH] Revert disabled look of minimized task icons
Commit 8b5d78dd4213eb110a156fd73a7ca9323afb6f2d ("disabled look to
minimized tasks") added disabled look to minimized task icons in
addition to the existing task text. It also changed the disabled look to
appear only when "Show only minimized tasks" configuration option is
disabled.
However, changing task icons to appear as disabled degrades the
usability for some people, and adding a configuration option for that
is too late due to the messages freeze. In addition, feature freeze is
in effect, so the feature is reverted.
The second change of not always showing the disabled look is not
reverted.
---
plasma/desktop/applets/tasks/abstracttaskitem.cpp | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/plasma/desktop/applets/tasks/abstracttaskitem.cpp b/plasma/desktop/applets/tasks/abstracttaskitem.cpp
index 988b6a8..7967374 100644
--- a/plasma/desktop/applets/tasks/abstracttaskitem.cpp
+++ b/plasma/desktop/applets/tasks/abstracttaskitem.cpp
@@ -684,15 +684,7 @@ void AbstractTaskItem::drawTask(QPainter *painter, const QStyleOptionGraphicsIte
kDebug() << bool(option->state & QStyle::State_MouseOver) << m_backgroundFadeAnim <<
(m_backgroundFadeAnim ? m_backgroundFadeAnim->state() : QAbstractAnimation::Stopped);*/
const bool fadingBg = m_backgroundFadeAnim && m_backgroundFadeAnim->state() == QAbstractAnimation::Running;
-
- //disabled look if the task is minimized
- //AND show only minimized tasks is disabled
- if ((m_flags & TaskIsMinimized) && !m_applet->groupManager().showOnlyMinimized()) {
- KIconEffect *effect = KIconLoader::global()->iconEffect();
- QPixmap result = icon().pixmap(iconR.toRect().size());
- result = effect->apply(result, KIconLoader::Desktop, KIconLoader::DisabledState);
- painter->drawPixmap(iconR.topLeft(), result);
- } else if ((!fadingBg && !(option->state & QStyle::State_MouseOver)) ||
+ if ((!fadingBg && !(option->state & QStyle::State_MouseOver)) ||
(m_oldBackgroundPrefix != "hover" && m_backgroundPrefix != "hover")) {
// QIcon::paint does some alignment work and can lead to funny
// things when icon().size() != iconR.toRect().size()
--
1.7.10
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
