On Tue, Nov 9, 2010 at 18:58, Raphael Kubo da Costa <kub...@gmail.com> wrote: > On Wednesday 10 November 2010 00:16:43 Jeffery MacEachern wrote: >> Hi all, >> >> I'm planning to commit a patch[0] to KNotify shortly, but I am >> uncertain of whether or not my edits to the CMakeLists.txt file are >> done The Right Way (it builds fine, but I suspect I've missed some >> finer points). Could someone take a brief glance and let me know if >> I've made any newbie mistakes? >> >> Thanks, >> - Jeffery MacEachern >> >> [0]: http://svn.reviewboard.kde.org/r/5458/ > > The CMake changes look fairly minimal, and there doesn't seem to be anything > suspecious from a 2-second look ;) > > If you're in doubt about CMake-related stuff, I suggest mailing the kde- > buildsystem ML instead of kde-devel.
Thanks, I will keep that in mind. I just wanted a sanity-check. :) Cheers, - Jeffery MacEachern >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
