El dilluns, 19 de juliol de 2021, a les 14:54:26 (CEST), George Florea Banus va
escriure:
> Hello
>
> I would like to move Haruna to KDEReview.
>
> Haruna is a media player based on mpv, focus is on video playback.
>
> https://invent.kde.org/multimedia/haruna
You need a
KLocalizedString::setApplicationDomain("haruna")
just after creating your QApplication. Otherwise translations are not going to
be loaded.
The menus look&feel is a bit broken (separators and highlight being drawn past
the actual menu width, icons being painted "blurrily"), but i guess that's not
really your fault.
The Setting has a "Help!" <- remove the !
in that "Help!" menu you have a KHelpCenter entry that should be called "Haruna
handbook" like in the rest of applications.
The first time i open the app the "Color scheme" combo box doesn't have
contents, given there's a default entry i'd expect to see that.
The "english only" help is kind of weird. Why are you using html for that?
Seems like something you should do with tooltips and if those QML components
don't support tooltips, at least make the help page with QML so it's
translatable?
I've no idea what the "Open config..." entries in the settings menu are
supposed to do, but both fail with "file doesn't exist" for me.
Esc not only exits fullscreen (good) but enters fullscreen (weird).
The "Primary Subtitle" MenuItem that tries to be a title is kind of weird
because it has exactly the same look&feel that the other menus, at least
disable clicking on it, because i can click on it and then it's even more
confusing if it's really wants to be a title or not without reading the code :D
It does remember the last thing i was playing, which I dislike, I tried to look
for a config option to disable it but doesn't seem to be one. Feel free to
ignore this.
The thing you call Header in View -> "Hide header" is called historically
called toolbar, i think you should rename it.
All in all, the app is nice, but IMHO suffers a bit from being QML based and
not being able to use KXMLGUI.
Cheers,
Albert
