Le jeudi, mars 25, 2021 4:47 PM, Harald Sitter <sit...@kde.org> a écrit :
> - really close to 100% reuse cover. plz consider adding data to
> KQuickImageEditorConfig.cmake.in and src/controls/plugins.qmltypes
>
> - in fact... shouldn't the qmltypes file be generated at build time?
> - there's commented out KDEFrameworkCompilerSettings in CMakeLists,
> please remove it, Friedrich asked us to not use it outside frameworks
> and having it commented out only tempts people into using it ;)
>
> - as with koko, it might make sense to bump the kf5 requirement to
> 5.79 and use clang format+hooks. there are some stilistic
> inconsistency within the code already
>
> - you should consider adding an option() definition for the
> BUILD_SHARED_LIBS variable so it is documented and expicitly
> initialized to a default value, I guess
>
> - ResizeRectangle has raw pointers that aren't initialized to nullptr by
> default
> - resizerectangle.cpp includes moc_resizerectangle.cpp is there a
> reason for that? shouldn't automoc magic do this on its own?
>
> - same for resizehandle.cpp
>
> some typos in imagedocument.h:
> Mirrror
> horizonal (actually in mirrocommand.{h,cpp} as well)
> operation
Thanks for the review and sorry for the delay. I just made the changes :)
>
> HS
>
