Hi, On 4/3/21 1:26 PM, Albert Astals Cid wrote:
clang complains that/home/tsdgeos/devel/kde/layer-shell-qt/src/qwaylandlayershell_p.h:23:24: note: did you mean class here? QWaylandLayerShell(struct QtWayland::zwlr_layer_shell_v1 *shell); ^~~~~~ class
https://invent.kde.org/plasma/layer-shell-qt/-/merge_requests/2 should fix it.
clazy complains that /home/tsdgeos/devel/kde/layer-shell-qt/src/qwaylandlayersurface.cpp:72:39: error: Pass small and trivially-copyable type by value (const class QMargins &) [-Wclazy-function-args-by-value] void QWaylandLayerSurface::setMargins(const QMargins &margins)
In fairness, a lot of plasma projects pass QMargins objects via const ref and it's hard to tell what Qt types are trivially copyable.
There are two TODO in the code, how important they are, should they be done before release?
Some of those TODO comments require changes in QtWayland, which arguably can be done only in the Qt 6 timeframe.
Cheers, Vlad
