On 15.02.21 07:16, Bhushan Shah wrote: > Forwarding message, since had wrong reply to address in previous message > > ----- Forwarded message from Bhushan Shah <bs...@mykolab.com> ----- > > Date: Mon, 15 Feb 2021 11:44:14 +0530 > From: Bhushan Shah <bs...@mykolab.com> > To: Harald Sitter <sit...@kde.org> > Subject: Re: New repo in kdereview: plasma-settings > > On Mon, Jan 25, 2021 at 03:29:18PM +0100, Harald Sitter wrote: >> Not sure if intentional but ModulesModel actually doesn't constrain to >> settings KCMS. It'd also display info center kcms as well as (I think) >> plugin KCMS (e.g. krunner's) > > It is not intentional, but thinking about this I think it is fine, we > are filtering them out based PLASMA_PLATFORM anyway. > >> not installing a hicolor icon > > We are reusing system settings icon from theme anyway, so not sure if I > need to install something?
Fair points. +1 HS
signature.asc
Description: OpenPGP digital signature