> On Oct. 17, 2016, 12:13 p.m., Aleix Pol Gonzalez wrote: > > I'm not sure it's a very good idea to introduce behavior changes in kdelibs > > 4. Why can't you use kde-open from kf5? > > Gerhard Gappmeier wrote: > Because I'm running KDE4 on many machines and want this bug fixed. It's > not a solution to switch the newer OS and KDE version. > I think there are still many KDE4 users out there (debian wheezy). > Also I'm not sure if this is fixed in KF5. We should check that, but I > don't have if it running here. Can you verify that this is fixed in KF5? > > Aleix Pol Gonzalez wrote: > In KF5 this code moved to QUrl (KUrl is in KDELibs4Support there, not > used by kde-open). > > Albert Astals Cid wrote: > > Can you verify that this is fixed in KF5? > > How would one test this from the user point of view (i.e using kde-open5) > > Gerhard Gappmeier wrote: > This is best explained here: > http://edoceo.com/howto/xfce-custom-uri-handler > I added the following to my .local/share/applications/mimeapps.list > x-scheme-handler/opcua=UaExpert.desktop > x-scheme-handler/opc.tcp=UaExpert.desktop > > then I added the mimetype to my .desktop file: > MimeType=x-scheme-handler/opcua;x-scheme-handler/opc.tcp > > opcua works > opc.tcp does not (without the fix) > > I think you can test this with every application like e.g. kwrite. > It only needs to get started, it doesn't need to handle the URI.
seems to work - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129208/#review100093 ----------------------------------------------------------- On Oct. 22, 2016, 2:29 p.m., Gerhard Gappmeier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129208/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2016, 2:29 p.m.) > > > Review request for kdelibs and Thiago Macieira. > > > Repository: kdelibs > > > Description > ------- > > RFC3986 defines the following syntax for URI schemes > scheme = alpha *( alpha | digit | "+" | "-" | "." ) > > The '.' was missing which leaded to the problem that > xdg-open opc.tcp://localhost didn't work. > > Background: > xdg-open calls kde-open which then uses KUrl and so leaded to this > problem. Of course this bug may affect also many other locations > using KUrl::isRelativeUrl. > > This fix also adds a unit test to test the fix and avoid future > regressions. > > > Diffs > ----- > > kdecore/io/kurl.cpp d9661eab5f8df3bfbbd2900246437fb129037dba > kdecore/tests/kurltest.cpp 3947724bfd1d26ad69b97789205a814a8d712591 > > Diff: https://git.reviewboard.kde.org/r/129208/diff/ > > > Testing > ------- > > > Thanks, > > Gerhard Gappmeier > >
