-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/
-----------------------------------------------------------
(Updated März 16, 2016, 4:35 nachm.)
Review request for kde-workspace and Plasma.
Changes
-------
Use single Date object
Bugs: 347724
https://bugs.kde.org/show_bug.cgi?id=347724
Repository: plasma-workspace
Description
-------
Currently the width of the date label is not fixed but changes depending on the
text. This causes the entire applet to change its width (if the time is the
widest displayed item). This in turn can cause all other applets in the same
panel to move whenever the displayed time changes.
This patch uses FontMetrics to iterate over all possible time strings (with
different width) and chooses the widest of them as reference for the fixed
width of the time label.
This way the width of the applet stays the same (unless the date is displayed
and changes). The text remains centered though, which means that it can still
move within the applet when the time changes.
Diffs (updated)
-----
applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071
Diff: https://git.reviewboard.kde.org/r/127102/diff/
Testing
-------
Works with horizontal and vertical panel.
Also displaying different combinations of "seconds", "date" and "timezone"
works.
File Attachments (updated)
----------------
0001-Use-fixed-width-for-digital-clock-applet.patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/81b4a902-1454-4155-9fda-552b8acba1a8__0001-Use-fixed-width-for-digital-clock-applet.patch
Thanks,
Daniel Faust
