----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/#review86362 -----------------------------------------------------------
Ship it! app/addToArchiveDndPlugin.cpp (line 38) <https://git.reviewboard.kde.org/r/119890/#comment59486> Empty new line. Plus this entire function is idented in a strange way. app/addToArchiveDndPlugin.cpp (line 44) <https://git.reviewboard.kde.org/r/119890/#comment59489> const KUrl& i app/addToArchiveDndPlugin.cpp (line 59) <https://git.reviewboard.kde.org/r/119890/#comment59487> Extra indent over here. app/addToArchiveDndPlugin.cpp (line 70) <https://git.reviewboard.kde.org/r/119890/#comment59488> The * is next to the type in the rest of the file. `KAction* action` instead of `KAction *action`. - Vishesh Handa On Aug. 21, 2014, 9:11 p.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119890/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 9:11 p.m.) > > > Review request for KDE Base Apps and KDE Utils. > > > Bugs: 338414 > http://bugs.kde.org/show_bug.cgi?id=338414 > > > Repository: ark > > > Description > ------- > > This patch implements the "Add to archive" option, which is shown when a user > drags and drops files onto an existing archive. > > > See also: > https://git.reviewboard.kde.org/r/119892 > https://bugs.kde.org/show_bug.cgi?id=338414 > > > Diffs > ----- > > app/ark_dndaddtoarchive.desktop.cmake PRE-CREATION > app/CMakeLists.txt f1ef01b > app/addToArchiveDndPlugin.h PRE-CREATION > app/addToArchiveDndPlugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119890/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
