El Dijous, 16 d'abril de 2015, a les 15:18:53, šumski va escriure: > On Thursday 09 of April 2015 23:00:30 Albert Astals Cid wrote: > > El Dimecres, 8 d'abril de 2015, a les 19:49:37, šumski va escriure: > > > On Monday 06 of April 2015 15:26:43 Albert Astals Cid wrote: > > > > El Diumenge, 5 d'abril de 2015, a les 20:47:03, šumski va escriure: > > > > > Hi all, > > > > > > > > > > In review 120393 [1] it was suggested to remove all code that hasn't > > > > > compiled at least since 5.0.0. Nepomuk parts won't work even if the > > > > > #if's > > > > > would be correctly adjusted, as there isn't Qt5 based soprano, but > > > > > strigi > > > > > ones in theory should, if the find_package call would be restored. > > > > > The libstreams and libstreamanalyzer libs are Qt-agnostic, strigi > > > > > can only use Qt for the GUI daemon client. > > > > > > > > > > Now i got suggestion by Vishesh and Albert to ask for a general > > > > > decision regarding strigi-related code. > > > > > IMO the code should be killed, as the classes are deprecated even in > > > > > kdelibs4 code, so there isn't much point in bringing it all back in > > > > > kdelibs4support, even though lxr.kde.org still shows some users... > > > > > > > > Can you point to the search you made in lxr.kde.org to know how many > > > > users are out there to have a better view of what it means removing it > > > > altogether? > > > > > > Sure, > > > http://lxr.kde.org/ident?v=kf5-qt5&_i=KFileMetaInfo&_remember=1 > > > > There's some users, since it is like 2 lines to fix it, i don't see why we > > shouldn't just fix it. > > I'm not sure which those line are =) There are no porting notes afaics for > KFileMetaInfo...
By fixing it, i mean enabling strigi, it should just be a matter of adding a few cmake calls, no? Cheers, Albert > > > Cheers, > Hrvoje > > > Cheers, > > > > Albert > > > > > Cheers, > > > Hrvoje > > > > > > > Cheers, > > > > > > > > Albert > > > > > > > > > What do others think? > > > > > > > > > > [1]: https://git.reviewboard.kde.org/r/120393/
signature.asc
Description: This is a digitally signed message part.
