----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review79059 -----------------------------------------------------------
Approach looks good to me, just a few minor cleanup comments below. CMakeLists.txt (lines 22 - 33) <https://git.reviewboard.kde.org/r/122249/#comment54028> do we still need all those? I only see GlobalAccel used as a new dependency or am I missing something? processui/ksysguardprocesslist.cpp (line 344) <https://git.reviewboard.kde.org/r/122249/#comment54024> please add a context for translators. I think a generic "no set" is quite difficult to translate. processui/ksysguardprocesslist.cpp (lines 353 - 361) <https://git.reviewboard.kde.org/r/122249/#comment54025> not sure about the "deadly skull" and whether that's generically true. The cursor name is "pirate". processui/ksysguardprocesslist.cpp (line 359) <https://git.reviewboard.kde.org/r/122249/#comment54026> You could know whether kwin is used - the window manager name is exported to the root window. Users might not know what "KWin" is. processui/ksysguardprocesslist.cpp (line 1521) <https://git.reviewboard.kde.org/r/122249/#comment54027> nitpick: added empty line - Martin Gräßlin On April 10, 2015, 1:23 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122249/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 1:23 p.m.) > > > Review request for KDE Base Apps, Martin Gräßlin and John Tapsell. > > > Repository: libksysguard > > > Description > ------- > > Current situation: > The "End Process..." button has a tooltip which says "To target a specific > window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is > hardcoded. > > New: > Replace the "End Process..." button with a drop-down button and a action > named "Kill a specific window..." > > > Diffs > ----- > > processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 > CMakeLists.txt 66899e577a03786d894423a8f1ce5b3aeed6de8a > processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c > processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 > > Diff: https://git.reviewboard.kde.org/r/122249/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > New End Process button with drop down arrow > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png > new submenu > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png > new message box > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png > > > Thanks, > > Gregor Mi > >
