> On Фев. 4, 2015, 9:16 д.п., Martin Gräßlin wrote: > > startkde/kcminit/CMakeLists.txt, line 6 > > <https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6> > > > > you forgot to git add the config-xcb.h.cmake
i know. its contents is the following: /* Define if you have XCB at all */ #cmakedefine XCB_FOUND are there any other issues apart this one? - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 ----------------------------------------------------------- On Фев. 4, 2015, 12:31 д.п., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122320/ > ----------------------------------------------------------- > > (Updated Фев. 4, 2015, 12:31 д.п.) > > > Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. > > > Repository: plasma-workspace > > > Description > ------- > > this patch makes kcminit behave like in kde4: it uses proper xcb screen count > which may be different from QGuiApplication::screens().count(). > > for example when i connext external monitor via vga to my laptop, xcb screen > count is still '1', while QGuiApplication::screens().count() returns '2'. > > switching from QGuiApplication to QCoreApplication still wasn't possible > because modules like 'mouse' need gui initialized and would crash if kcminit > uses QCoreApplication. > > > Diffs > ----- > > startkde/kcminit/CMakeLists.txt b17951f > startkde/kcminit/main.cpp 1008966 > > Diff: https://git.reviewboard.kde.org/r/122320/diff/ > > > Testing > ------- > > i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and > libraries in the system and successfuly could run kcminit_startup and reboot > also went fine. > > > Thanks, > > Nick Shaforostoff > >
