> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > <https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223> > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what remains being built on Apple is: > > * kcheckpass > > * qguiplatformplugin_kde > > > > Somehow I doubt kcheckpass will work on MacOS (it uses PAM) or is of > > any need (only used by kscreenlocker_greet in ksmserver which is not > > built). And qguiplatformplugin_kde should not be of any use on MacOS either > > because it's the Qt plugin for a Plasma session and shouldn't (TM) be used > > on other platforms. > > > > So if I see correctly you could just merge the whole thing into a > > if(NOT WIN32 AND NOT APPLE)
Are you very sure about that? I see things related to KFileDialog and KColorDialog, and I don't see why those would only be relevant from inside a Plasma session... What would be the best place where I could put some kind of output expression that I ought NOT to see if indeed the platform plugin isn't used? I also remember someone (Thomas?) mention it in the context of doing an override of a Qt setting at a very low, early level during application initialisation. - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67071 ----------------------------------------------------------- On Sept. 20, 2014, 2:52 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 2:52 p.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > ---------------- > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >
