> On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56> > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shouldn't that > empty line have been there in the 1st place?! > > Martin Gräßlin wrote: > yes of course. It's a change which has nothing to do with the overall > change. It's not atomic any more.
> shouldn't that empty line have been there in the 1st place?! c++98 newline @ EOF, later versions don't, ie. it's not required to add that line despite you may get warnings about it (and actually kate has an option to automatically add it on saving) Do you use xcode? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67023 ----------------------------------------------------------- On Sept. 19, 2014, 10:05 nachm., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 10:05 nachm.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > Thanks, > > René J.V. Bertin > >
