-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105895/
-----------------------------------------------------------
(Updated July 24, 2014, 6:46 p.m.)
Status
------
This change has been discarded.
Review request for KDE Base Apps.
Bugs: 156396
http://bugs.kde.org/show_bug.cgi?id=156396
Repository: kde-baseapps
Description
-------
When changing the user's full name, chfn may not necessarily produce any
output. Since readLine blocks, the kcm may hang.
This change checks if chfn exited without output, and if so, use that exit
status.
Diffs
-----
kdepasswd/kcm/chfnprocess.h c9f0700f51d0a749b43c75840c43b46ccadb538a
kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9
kdepasswd/kcm/main.cpp 5a5248e545cc75433024ae0464ac9f3e05b71900
Diff: https://git.reviewboard.kde.org/r/105895/diff/
Testing
-------
Tested all combinations of password required and name change permitted, with
success.
Thanks,
Michael Palimaka