----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review62821 -----------------------------------------------------------
lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment43567> this indention is wrong (ensure to use the present indention, usually 4 spaces per level and NO tabs) lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment43568> there are two whitespaces between "if" and "(" - not that the surrounding lines would be very white space consistent, but nevertheless ;-) lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment43569> Try to twist this: if (!local) ... else if (QFileInfo((*it).directory()).isWritable()) { QFileInfo pathInfo(QFileInfo((*it).path()); ... } This allows you to re-use the QFileInfo object w/o useless overhead and also removes a branch level. - Thomas Lübking On Juli 21, 2014, 2:12 nachm., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119372/ > ----------------------------------------------------------- > > (Updated Juli 21, 2014, 2:12 nachm.) > > > Review request for KDE Base Apps. > > > Bugs: 337486 > http://bugs.kde.org/show_bug.cgi?id=337486 > > > Repository: kde-baseapps > > > Description > ------- > > Fixes Bug 337486 > > > Diffs > ----- > > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119372/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
