----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62173 -----------------------------------------------------------
The patch is valid. My only question in this context would be whether there, and in case what, is a general strategy on dealing CF functions (ie. is the absence of such "auxiliary" widget a legal condition and if not, should actually the client code be responsible to prevent this state. See string conversion case linked on bug) Since i can't answer that question, and aside the WS issue: "+1" kdeui/windowmanagement/kwindowinfo_mac.cpp <https://git.reviewboard.kde.org/r/119240/#comment43211> whitespace: "if (m_axWin) {" - Thomas Lübking On Juli 12, 2014, 9:24 vorm., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119240/ > ----------------------------------------------------------- > > (Updated Juli 12, 2014, 9:24 vorm.) > > > Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. > > > Bugs: 337154 > http://bugs.kde.org/show_bug.cgi?id=337154 > > > Repository: kdelibs > > > Description > ------- > > Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to > René J.V. Bertin) > > > Diffs > ----- > > kdeui/windowmanagement/kwindowinfo_mac.cpp > ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 > > Diff: https://git.reviewboard.kde.org/r/119240/diff/ > > > Testing > ------- > > For more details see associated bug > > > Thanks, > > Marko Käning > >
