----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119211/#review62085 -----------------------------------------------------------
But why CMD_REPARSECONFIGURATION especially? If the slave is on hold, will anything else get through? IOW should the test just be extended with "|| suspended", no test on cmd? - David Faure On July 10, 2014, 12:04 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119211/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 12:04 p.m.) > > > Review request for kdelibs, David Faure and Thiago Macieira. > > > Repository: kdelibs > > > Description > ------- > > This patch addresses the issue where attempting to send > CMD_REPARSECONFIGURATION to suspended ioslaves results in a freezing of the > application that sent the request. This problem can be clearly reproduced by > following the steps outlined in the bug report. > > I am not entirely sure whether or not this fix really belongs in > kio/connection.cpp, but I could not find a more convenient location to queue > the command request to ensure the ioslave receives the reparse configuration > command if it is ever reused again. > > > Diffs > ----- > > kio/kio/connection.cpp 99aea0b > > Diff: https://git.reviewboard.kde.org/r/119211/diff/ > > > Testing > ------- > > Run the steps given in the bug report before and after the fix. > > > Thanks, > > Dawit Alemayehu > >
