----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/#review61956 -----------------------------------------------------------
Ship it! kcontrol/fonts/fonts.cpp <https://git.reviewboard.kde.org/r/117957/#comment43133> Instead of this "hack", I would personally call the slot at the end of the constructor, and let load() call it again if the loaded value is different from 0 (via the connect to currentIndexChanged). But I guess that's a matter of taste (-1 looks hackish to me -- but indeed it's documented as a way to ensure no current index). So, no veto. - David Faure On July 6, 2014, 10:28 a.m., Andrea Iacovitti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117957/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 10:28 a.m.) > > > Review request for kde-workspace. > > > Bugs: 324728 > http://bugs.kde.org/show_bug.cgi?id=324728 > > > Repository: kde-workspace > > > Description > ------- > > When restoring default configuration: > - Disable "Exclude range checkbox" > - Enable/Disable "Configure..." button accordingly to antialias setting > > > Diffs > ----- > > kcontrol/fonts/fonts.cpp cf21cb1 > > Diff: https://git.reviewboard.kde.org/r/117957/diff/ > > > Testing > ------- > > Tested it compiles and works as expected > > > Thanks, > > Andrea Iacovitti > >
