> On jul 5, 2014, 1:11 p.m., Mark Gaiser wrote: > > src/filewidgets/knewfilemenu.cpp, lines 875-878 > > <https://git.reviewboard.kde.org/r/119130/diff/1/?file=287354#file287354line875> > > > > You should be able to replace this with: > > files.append(dir.entryList(QStringList() << "*.desktop", QDir::Files)); > > > > Yes, append also takes a QList<T> container type. If that doesn't work > > then you also have the option of doing: > > files += dir.entryList(QStringList() << "*.desktop", QDir::Files); > > > > Cool huh, one liners? :) > > Eike Hein wrote: > entryList() doesn't return full absolute paths, only file names, so your > one liner isn't actually functionally equivalent (and full paths are needed > there).
Ahh, you're right. My bad. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/#review61646 ----------------------------------------------------------- On jul 5, 2014, 1:26 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119130/ > ----------------------------------------------------------- > > (Updated jul 5, 2014, 1:26 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kio > > > Description > ------- > > KNewFileMenu was incorrectly ported to QStandardPaths, listing directories > where it actually wants to collect template files within them. This patch > fixes it. > > > Diffs > ----- > > src/filewidgets/knewfilemenu.cpp 4f1ca10 > > Diff: https://git.reviewboard.kde.org/r/119130/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
