----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/ -----------------------------------------------------------
(Updated June 18, 2014, 1:24 p.m.) Review request for KDE Base Apps and Eike Hein. Changes ------- Now it doesn't crash yakuake for exit or closing the tab by the - button. Splitting the view and closing one of the split still crashes though, but the crash is in yakuake code rather than konsole code. Repository: konsole Description ------- When containers are destructed, they emit a signal that the splitter is connected to which removes and unregisters the container from the splitter. A crash happens when the splitter is destroyed before the container, so a slot in a deleted splitter is called, tries to unregister the container, and segfaults. I added a destructor to ViewSplitter which unregisters all it's containers, this fixes the crash here on closing of a tab in yakuake and on closing a tab in konsole. Diffs (updated) ----- src/ViewSplitter.h c1e4552 src/ViewSplitter.cpp bfc727e src/ViewContainer.cpp 79c24d5 Diff: https://git.reviewboard.kde.org/r/118816/diff/ Testing ------- Manual testing, it seems to work fine. Thanks, Jeremy Whiting
