On Tuesday 07 January 2014 23:30:28 John Layt wrote: > On 7 January 2014 19:49, Kevin Ottens <er...@kde.org> wrote: > >> Most of the > >> dialog code from there has been merged into Qt5.2, or is planned for > >> Qt 5.3, so needs deleting. I'm also wondering if we still need our > >> own KPrintPreview dialog, there was a reason in 4.0 but I can't > >> remember why now and I'm not sure it is still valid. Alex Merry might > >> remember, was it because QPrintPreview wasn't available at the time? > >> We may not end up with much left here :-) > > > > Well, the initial plan was to not have KPrintUtils at all. It's here > > mainly > > because of timing issues because the necessary upstream work to get > > everything to disappear in KPrintUtils wasn't done in time for Qt 5.2. > > Running through the print dialog features, I'm don't think there is > anything left to be upstreamed. There's a couple of very minor CUPS > features in the dialog that I don't think anyone uses (mirror page, > page border, page label) that I don't really want in Qt, but can add > if anyone really makes a fuss. If we decide to replace KPrintPreview > with QPrintPreviewDialog then we're just left with the convenience api > to create a QPrintDialog that won't actually add anything extra. That > could be still worth keeping for a couple of reasons, but it could > then move to KGuiAddons.
For the record, if that depends on QtPrintSupport it can't make it to KGuiAddons (which should depend only on QtCore and QtGui). > The main reason to keep it is > future-proofing if we need to add common widgets or extra checks > again, in particular I think it may be the only way to do > color-managed printing until Qt adds proper support in QtGui. I'm fine keeping it even if it's small. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
