----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113608/#review46250 -----------------------------------------------------------
We definitely need an update of the UA browser versions indeed, but I'm a bit unsure about the use of "latest" to replace version numbers. As a user, it means I have no way to see if this is using some recent version number or some old one because we again forgot to update it. So if e.g. the website says "your browser is unsupported", it becomes harder to know what the problem is. - David Faure On Nov. 4, 2013, 7:54 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113608/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 7:54 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > I recently needed to swith user agents to (very) new browser versions. This > is an attempt to add them upstream. > Since browser makers release new version every other week it seems useless to > make a new file for each one. I just named it latest and don't include the > version number in the description. > That way translators have no extra work when we update the user agent. > > > Diffs > ----- > > konqueror/settings/kio/uasproviders/android_latest.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/chrome_latest.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/firefox_latest.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/ie_latest.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/113608/diff/ > > > Testing > ------- > > > Thanks, > > Maarten De Meyer > >
