> On Nov. 5, 2013, 1:51 p.m., Aurélien Gâteau wrote: > > Looks good, thanks! > > > > Note: you should use the "kdeframeworks" group instead of the "kdelibs" > > group for KF5 review requests.
Sorry for the inconvenience, I fixed my other reviews accordingly. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644/#review43056 ----------------------------------------------------------- On Nov. 5, 2013, 1:36 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113644/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 1:36 p.m.) > > > Review request for kdelibs and Aurélien Gâteau. > > > Repository: kdelibs > > > Description > ------- > > Fix name of package to find. > > > Diffs > ----- > > tier2/kwallet/CMakeLists.txt 8700907 > > Diff: http://git.reviewboard.kde.org/r/113644/diff/ > > > Testing > ------- > > 1. Configure a standalone build for kwallet > > Before this patch, CMake would fail to find package KConfigCore > > > Thanks, > > David Narváez > >
