> On Nov. 5, 2013, 10:21 a.m., Kai Uwe Broulik wrote: > > ksplash/ksplashqml/themes/Classic/main.qml, line 29 > > <http://git.reviewboard.kde.org/r/113630/diff/1/?file=209049#file209049line29> > > > > Do we even need this? It's not like the splash did or would ever be > > resolution independent
I think with QML it could be...however I made this theme with fixed sizes as the icons are prefabbed with the mirror-and-fadeout-and-blur effect. The biggest icons could be used and then scaled down I guess...not sure how it would look. > On Nov. 5, 2013, 10:21 a.m., Kai Uwe Broulik wrote: > > ksplash/ksplashqml/themes/Classic/main.qml, line 33 > > <http://git.reviewboard.kde.org/r/113630/diff/1/?file=209049#file209049line33> > > > > David Edmundson put so much effort into making the switch from LightDm > > to the session as seamless as possible and now you make it black and fade > > in the wallpaper again? ;) Damn good point. Other thing is that there are plans to make the splash part of the DM itself so when it's moved there for realz, this would get fixed anyway. > On Nov. 5, 2013, 10:21 a.m., Kai Uwe Broulik wrote: > > ksplash/ksplashqml/themes/Classic/main.qml, lines 72-73 > > <http://git.reviewboard.kde.org/r/113630/diff/1/?file=209049#file209049line72> > > > > Then we don't need this? We don't. (QML Skill Level up!) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113630/#review43036 ----------------------------------------------------------- On Nov. 4, 2013, 8:22 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113630/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 8:22 p.m.) > > > Review request for kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > Last thing on my ksplash list is to port the good old KDE4 theme as "Classic" > theme done in QML. I'm a QML noob so I'm putting it up for some comments. It > works (and looks) just like the original theme. I reconstructed it using the > original images. > > I'll put it into kde-workspace/ksplash, where it can be further improved, > then it can be moved to some Look&Feel package later on. > > > Diffs > ----- > > ksplash/ksplashqml/themes/CMakeLists.txt c5ab367 > ksplash/ksplashqml/themes/Classic/CMakeLists.txt PRE-CREATION > ksplash/ksplashqml/themes/Classic/Preview.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/Theme.rc PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/background.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/icon1.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/icon2.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/icon3.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/icon4.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/icon5.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/images/rectangle.png PRE-CREATION > ksplash/ksplashqml/themes/Classic/main.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113630/diff/ > > > Testing > ------- > > Works just like in KDE4. > > > File Attachments > ---------------- > > Screenshot > > http://git.reviewboard.kde.org/media/uploaded/files/2013/11/04/b7596f8c-2df3-4e62-bcbd-ee0e5ad5afc4__ksplash_classic.png > > > Thanks, > > Martin Klapetek > >
