----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ -----------------------------------------------------------
(Updated Sept. 22, 2013, 4:09 p.m.) Review request for kdelibs. Changes ------- Have rewriten fully token class to use Q_INVOKABLE methods. It is better as 1) we don't need to store parameters 2) we don't need to create many KColorSchemeTokens for each color 3) it is more comfortable to use 4) we don't bother about nonsense NOTIFY, READ for parameters and nonsense NOTIFY for result. Description ------- It is wrapper to access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. More info: * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists * NEED TO FIX: I can't include it like #include <KColorSchemeToken> at KReversi's code, only "kcolorschemetoken.h". Maybe I've missed something? Diffs (updated) ----- kdeui/colors/kcolorschemetoken.cpp PRE-CREATION kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorscheme.h 17570fd kdeui/CMakeLists.txt b439e04 Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing ------- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov
