----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529/#review39462 -----------------------------------------------------------
as far as i can judge it, it looks OK to me. Someone else would have to give a ship it. - Mark Gaiser On Sept. 6, 2013, 1:04 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112529/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 1:04 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > The attached patch marks all files, directories, shares etc as hidden by > default. That what the GUI applications can correctly hide them and only make > them visible when the "Show Hidden Files" option is checked. > > > This addresses bug 197903. > http://bugs.kde.org/show_bug.cgi?id=197903 > > > Diffs > ----- > > kioslave/smb/kio_smb_browse.cpp fec6449 > > Diff: http://git.reviewboard.kde.org/r/112529/diff/ > > > Testing > ------- > > Tested against shares from a Windows 7 machine. > > > Thanks, > > Dawit Alemayehu > >