> On Aug. 16, 2013, 6:19 p.m., Albert Astals Cid wrote: > > kcontrol/dateandtime/dtime.cpp, line 101 > > <http://git.reviewboard.kde.org/r/112122/diff/1/?file=181483#file181483line101> > > > > Maybe just use KLocale::timeFomat()?
Was thinking about it, and feared users might change the default format in a way they could no longer correctly change the time. For example, by not including the seconds, or the AM/PM indicator. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112122/#review37973 ----------------------------------------------------------- On Aug. 16, 2013, 3:21 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112122/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 3:21 p.m.) > > > Review request for kde-workspace, Albert Astals Cid and John Layt. > > > Description > ------- > > In System Settings "Date and Time" respect user's 12/24 h preference for the > time edit. > > Not sure which branch(es) this should be committed to, as this may conflict > with future KLocale stuff? > > > This addresses bug 290823. > http://bugs.kde.org/show_bug.cgi?id=290823 > > > Diffs > ----- > > kcontrol/dateandtime/dtime.cpp 9bbfee1 > > Diff: http://git.reviewboard.kde.org/r/112122/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Feck > >
