----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review37114 -----------------------------------------------------------
This review has been submitted with commit 9b0b5ec1a6396b051f65bf23cdf9d9949aa9c3ec by Dawit Alemayehu to branch KDE/4.11. - Commit Hook On Aug. 2, 2013, 12:37 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111776/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 12:37 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > This patch is an improvement of https://git.reviewboard.kde.org/r/111585/ > such that KIO operations also update URLs in the clipboard. As such, all KIO > operations that rename, move or delete a file will always update the contents > of the clipboard. > > A couple of notes about this patch: > > - KIO::trash was left out from this patch because I am unsure whether it > should be treated like a delete or move operation. > - Move, rename and delete operations performed outside of KIO are not covered > by this patch and as such will not update URLs in the clipboard. Dealing with > non KIO modifications is outside the scope of this patch since it needs to be > dealt with outside of KIO. > > > This addresses bug 134960. > http://bugs.kde.org/show_bug.cgi?id=134960 > > > Diffs > ----- > > kio/kio/clipboardupdater.cpp 8ab9210 > kio/kio/clipboardupdater_p.h b07c320 > kio/kio/copyjob.cpp da19de5 > kio/kio/deletejob.cpp 7178424 > kio/kio/job.cpp 05d0ba2 > kio/kio/paste.cpp b4372ab > kio/tests/CMakeLists.txt b570aac > kio/tests/clipboardupdatertest.h PRE-CREATION > kio/tests/clipboardupdatertest.cpp PRE-CREATION > kio/tests/fileundomanagertest.h e909bb7 > kio/tests/fileundomanagertest.cpp 709938d > > Diff: http://git.reviewboard.kde.org/r/111776/diff/ > > > Testing > ------- > > Unite tests. > > > Thanks, > > Dawit Alemayehu > >
