----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111883/#review37102 -----------------------------------------------------------
Ship it! Looks good, please also revert the NoGUI->GUI changes to the unittests. - David Faure On Aug. 5, 2013, 6:46 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111883/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2013, 6:46 a.m.) > > > Review request for kdelibs, Albert Astals Cid and David Faure. > > > Description > ------- > > Attached patch fixes runtime regression discussed here: > http://lists.kde.org/?t=137554003100003&r=1&w=2. Basically, it restores the > ability of unit tests to run without enabling GUI in QApplication. > > > Diffs > ----- > > kio/kio/clipboardupdater.cpp 821ef1e > kio/kio/clipboardupdater_p.h e3d32bd > kio/kio/copyjob.cpp fbe3cc7 > kio/kio/deletejob.cpp a822373 > kio/kio/fileundomanager.cpp f0f4168 > kio/kio/job.cpp c7c354f > kio/kio/paste.cpp 62490bb > > Diff: http://git.reviewboard.kde.org/r/111883/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
