> On May 2, 2013, 9:30 a.m., David Faure wrote: > > kurifilter-plugins/ikws/searchproviderdlg.cpp, line 68 > > <http://git.reviewboard.kde.org/r/110247/diff/1/?file=141528#file141528line68> > > > > The argument is not necessary, Clipboard is the default value.
Fixed both problems locally. Thank you for the review :) - Maarten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110247/#review31875 ----------------------------------------------------------- On May 2, 2013, 11:53 a.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110247/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 11:53 a.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > When making a new web shortcut check the clipboard, if it's a url put it in > the query line edit. > Just a little time saver. (akregator does something similar) > > I used !host().isEmpty() because isValid() is almost always valid. > This will give false positives where the wrong link is placed inside the > query box. > > > This addresses bug 146880. > http://bugs.kde.org/show_bug.cgi?id=146880 > > > Diffs > ----- > > kurifilter-plugins/ikws/searchproviderdlg.cpp 2bb2852 > > Diff: http://git.reviewboard.kde.org/r/110247/diff/ > > > Testing > ------- > > Tested some url's and some random text. Only a url gets selected from the > clipboard. > > > Thanks, > > Maarten De Meyer > >
