----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110091/#review31332 -----------------------------------------------------------
cmake/modules/FindLibdevinfo.cmake <http://git.reviewboard.kde.org/r/110091/#comment23350> Why is this necessary at all? If you don't have a strong reason for it just drop it. cmake/modules/FindLibdevinfo.cmake <http://git.reviewboard.kde.org/r/110091/#comment23356> Please read Modules/readme.txt from CMake about how to name such variables. Short: this should be DEVINFO_INCLUDE_DIR, and you should have a DEVINFO_INCLUDE_DIRS later, which is not cached. cmake/modules/FindLibdevinfo.cmake <http://git.reviewboard.kde.org/r/110091/#comment23352> Has the header a version number one could parse out and use? kinfocenter/Modules/base/CMakeLists.txt <http://git.reviewboard.kde.org/r/110091/#comment23351> The TODO comment above can go away now I think. kinfocenter/Modules/base/info_fbsd.cpp <http://git.reviewboard.kde.org/r/110091/#comment23353> Why not just use QProcess here to get the result? I fear this stuff dates back to QT(<=3) times where this probably had issues, but that isn't true anymore. kinfocenter/Modules/base/info_fbsd.cpp <http://git.reviewboard.kde.org/r/110091/#comment23354> QProcess here, too. Otherwise it may be a good idea to just put your patch in now as it is and do a followup patch that just kills that function and replaces it with QProcess, or keeps that functions and gives it a proper QProcess-based interface, i.e. separate arguments passed as a QStringList and such. kinfocenter/Modules/base/info_fbsd.cpp <http://git.reviewboard.kde.org/r/110091/#comment23355> This line is flagged to have inconsistent whitespace. kinfocenter/Modules/info/CMakeLists.txt <http://git.reviewboard.kde.org/r/110091/#comment23357> I miss a include_directories(${DEVINFO_INCLUDE_DIRS}) or something like that here. - Rolf Eike Beer On April 19, 2013, 10:14 p.m., Max Brazhnikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110091/ > ----------------------------------------------------------- > > (Updated April 19, 2013, 10:14 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > Add FindLibdevinfo.cmake > Clean up info_fbsd.cpp and utilize PCIUtils > > > Diffs > ----- > > cmake/modules/FindLibdevinfo.cmake e69de29 > kinfocenter/Modules/base/CMakeLists.txt 2b3c34e > kinfocenter/Modules/base/info_fbsd.cpp 6bbaa1a > kinfocenter/Modules/info/CMakeLists.txt dba6bc7 > > Diff: http://git.reviewboard.kde.org/r/110091/diff/ > > > Testing > ------- > > > Thanks, > > Max Brazhnikov > >
