----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109935/#review30912 -----------------------------------------------------------
This review has been submitted with commit 8f8e3c27005b9d32b31cb6de5fd162a68c2a736b by Aurélien Gâteau to branch master. - Commit Hook On April 9, 2013, 3:56 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109935/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 3:56 p.m.) > > > Review request for kdelibs and Kevin Ottens. > > > Description > ------- > > When user moves an item from the model by dragging it, KFilePlacesModel > removes the item row and adds it back at the new position. This patch changes > this behavior to use beginMoveRows() and endMoveRows() instead. > > I came upon this while implementing drag'n'drop to reorder items in Homerun. > Homerun uses KFilePlacesModel in the "favorite places" source, and the > reordering code expects the model to use beginMoveRows() and endMoveRows(). > > > Diffs > ----- > > kfile/kfileplacesmodel.cpp 0192926233bac62596e4c04b9267229f4a284c95 > kfile/tests/kfileplacesmodeltest.cpp > 2ae9b7548e47985369dc896086031c07bf0c5a4c > > Diff: http://git.reviewboard.kde.org/r/109935/diff/ > > > Testing > ------- > > Tested with Homerun and other applications using KFileDialog. Updated the > unit-tests. > > > Thanks, > > Aurélien Gâteau > >
