> On March 14, 2013, 8:36 a.m., David Faure wrote: > > khtml/imload/decoders/gifloader.cpp, line 361 > > <http://git.reviewboard.kde.org/r/109478/diff/1/?file=119702#file119702line361> > > > > What's "e" ? an error code? Please rename the variable then, for more > > readability.
Indeed an error code, variable renamed to errorCode - Raymond ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29173 ----------------------------------------------------------- On March 14, 2013, 8:11 a.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109478/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 8:11 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > This patch makes kdelibs compile with the newest giflib v5, while maintaining > backwards compatibility. > > > Diffs > ----- > > khtml/imload/decoders/gifloader.cpp ebbb749 > > Diff: http://git.reviewboard.kde.org/r/109478/diff/ > > > Testing > ------- > > kdelibs compiles successfully with both giflib v5 and giflib v4 > > > Thanks, > > Raymond Wooninck > >
