> On Jan. 9, 2013, 6:43 p.m., Albert Astals Cid wrote: > > To be honest i don't think this is the correct fix, the correct fix is > > specifying a minimum space between the items or a minimum size of the items > > themselves, not forcing the wordwrapping off > > Thomas Lübking wrote: > itemsize (spacing would also increase space between text) and it's > actually the only way to fix the bug (look at the cn text of notifications or > a11y) and scales better when eg. egypt returned to hieroglyphs or so ;-) > > Chao Feng wrote: > I will try out this method if I have time. If a minimum size is set, the > problem of CJK language is indeed solved. But it will change the display of > other languages. For this kind of change, all major languages need to checked > to prevent another regression.
Here is another review request for this idea. See https://git.reviewboard.kde.org/r/108328/ - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25091 ----------------------------------------------------------- On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108285/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 4:33 a.m.) > > > Review request for kde-workspace. > > > Description > ------- > > CJK languages do not use space as words seperator. > > And a CJK translation of the text in Systemsettings are very short. A single > line is enough for them. > > > This addresses bug 234407. > http://bugs.kde.org/show_bug.cgi?id=234407 > > > Diffs > ----- > > systemsettings/icons/IconMode.cpp 37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e > > Diff: http://git.reviewboard.kde.org/r/108285/diff/ > > > Testing > ------- > > 1. Apply patch > 2. Systemsetting show ok on CJK > > > Thanks, > > Chao Feng > >
